Skip to content

chore(build): migrate to golangci-lint@v2 and golangci-lint-action@v7 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Mar 27, 2025

upgraded .golangci.yml with golangci-lint migrate

include fixes suggested by golangci-lint run -c ./.golangci.yml

Signed-off-by: Xavier Coulon xcoulon@redhat.com

upgraded `.golangci.yml` with `golangci-lint migrate`

include fixes suggested by `golangci-lint run -c ./.golangci.yml`

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon
Copy link
Contributor Author

xcoulon commented Mar 27, 2025

/test e2e

Co-authored-by: Lukas Krejci <metlos@users.noreply.github.com>
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (dc5ccac) to head (c8eef4c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/log/log.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          43       43           
  Lines        3518     3518           
=======================================
  Hits         2853     2853           
  Misses        578      578           
  Partials       87       87           
Flag Coverage Δ
unittests 81.09% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MatousJobanek
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, metlos, rajivnathan, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,metlos,rajivnathan,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Apr 1, 2025
Copy link

openshift-ci bot commented Apr 1, 2025

New changes are detected. LGTM label has been removed.

Copy link

sonarqubecloud bot commented Apr 1, 2025

@MatousJobanek MatousJobanek merged commit b52c1dc into codeready-toolchain:master Apr 2, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants